Skip to content

Reuse RefreshImportJidWorker from the new parallel GitHub importer for other importers

The following discussion from gitlab-ce!14731 should be addressed:

  • @DouweM started a discussion: (+6 comments)

    I think we could/should reuse this for all importers that may take more than 15minutes, like the simple Git repo importer, and even the fork worker.

The new parallel GitHub importer introduces a Sidekiq worker called Gitlab::GithubImport::RefreshImportJidWorker. This worker is used to refresh the import JID while a repository is being cloned, preventing the job from getting marked as stuck should the cloning process take more than 15 hours (rare, but technically possible).

Eventually we should reuse this worker for the other importers if possible, since it's generic enough. This could then be used to refresh the JID while the entire import runs, preventing it from getting marked as stuck while the job is still running.

Mind you that we may also need to adjust StuckImportJobsWorker accordingly, but I'm not 100% certain that would be necessary.

OSZAR »