Skip to content

Refactor the hook log "show" partials to a shared partial "shared/hook_logs/_show"

The following discussions from !94145 (merged) should be addressed:

  • @justin_ho started a discussion:

    Nit (non-blocking): I can see that this is pretty much copy-pasted from app/views/projects/hook_logs/show.html.haml (apart from the different breadcrumbs) so can we consider extracting this to a shared partial shared/hook_logs/_show. This will then make the rendering really simple on all levels project - group - admin.

    Of course this is just a nice to have so I think it's best done in a follow-up to limit the scope of these changes. Can you just create a new issue from this thread?

  • @anton started a discussion: (+2 comments)

    I'm not sure how to convert has-tooltip to the Pajamas format, even after looking at https://design.gitlab.com/components/tooltip/. This would also be an issue for the other hook types as well. Any thoughts on this?

Problem

Breadcrumbs and page titles are inconsistent

Solution

  • Page titles and breadcrumbs should generally be in sentence case (exceptions detailed in punctuation guidelines)
  • The breadcrumbs should follow the path that the user followed
Edited by Katie Macoy
OSZAR »